Revert "fix(workspace url id bug): switch workspace bug "#567
Merged
icecrasher321 merged 1 commit intostagingfrom Jun 27, 2025
Merged
Revert "fix(workspace url id bug): switch workspace bug "#567icecrasher321 merged 1 commit intostagingfrom
icecrasher321 merged 1 commit intostagingfrom
Conversation
This reverts commit 0049644.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
✅ No security or compliance issues detected. Reviewed everything up to 597f770. Security Overview
Detected Code Changes
Reply to this PR with |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR reverts significant workspace switching and workflow ordering changes from PR #564, potentially reintroducing several critical issues.
- Removed crucial database sorting by
lastModified descinapps/sim/stores/workflows/registry/store.ts, impacting workflow display consistency - Reverted workspace transition handling in
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx, which may reintroduce race conditions during switching - Simplified but potentially problematic workspace ID handling in
apps/sim/app/workspace/[workspaceId]/w/page.tsx, removing safeguards against duplicate loading - Removed optimistic UI updates and error handling in
workspace-header.tsx, making workspace switching less resilient - Eliminated workflow sorting by creation date in
apps/sim/app/api/workflows/sync/route.ts, affecting ordered workflow display
6 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
466
to
472
| // If deleted workspace was active, switch to another workspace | ||
| if (activeWorkspace?.id === id && updatedWorkspaces.length > 0) { | ||
| const newWorkspace = updatedWorkspaces[0] | ||
| setActiveWorkspace(newWorkspace) | ||
|
|
||
| // Use the specialized method for handling workspace deletion with explicit workspace ID | ||
| useWorkflowRegistry.getState().handleWorkspaceDeletion(newWorkspace.id) | ||
|
|
||
| // Update URL to the new workspace | ||
| router.push(`/workspace/${newWorkspace.id}/w`) | ||
| // Use the specialized method for handling workspace deletion | ||
| const newWorkspaceId = updatedWorkspaces[0].id | ||
| useWorkflowRegistry.getState().handleWorkspaceDeletion(newWorkspaceId) | ||
| setActiveWorkspace(updatedWorkspaces[0]) | ||
| } |
Contributor
There was a problem hiding this comment.
logic: Missing router.push after workspace deletion. User may remain on deleted workspace URL.
Suggested change
| // If deleted workspace was active, switch to another workspace | |
| if (activeWorkspace?.id === id && updatedWorkspaces.length > 0) { | |
| const newWorkspace = updatedWorkspaces[0] | |
| setActiveWorkspace(newWorkspace) | |
| // Use the specialized method for handling workspace deletion with explicit workspace ID | |
| useWorkflowRegistry.getState().handleWorkspaceDeletion(newWorkspace.id) | |
| // Update URL to the new workspace | |
| router.push(`/workspace/${newWorkspace.id}/w`) | |
| // Use the specialized method for handling workspace deletion | |
| const newWorkspaceId = updatedWorkspaces[0].id | |
| useWorkflowRegistry.getState().handleWorkspaceDeletion(newWorkspaceId) | |
| setActiveWorkspace(updatedWorkspaces[0]) | |
| } | |
| // If deleted workspace was active, switch to another workspace | |
| if (activeWorkspace?.id === id && updatedWorkspaces.length > 0) { | |
| // Use the specialized method for handling workspace deletion | |
| const newWorkspaceId = updatedWorkspaces[0].id | |
| useWorkflowRegistry.getState().handleWorkspaceDeletion(newWorkspaceId) | |
| setActiveWorkspace(updatedWorkspaces[0]) | |
| // Navigate to the new workspace | |
| router.push(`/workspace/${newWorkspaceId}/w`) | |
| } |
| .from(workflow) | ||
| .where(eq(workflow.workspaceId, workspaceId)) | ||
| .orderBy(desc(workflow.createdAt)) | ||
| workflows = await db.select().from(workflow).where(eq(workflow.workspaceId, workspaceId)) |
Contributor
There was a problem hiding this comment.
logic: Missing orderBy clause - workflows are no longer sorted by creation date which could affect frontend display order
Comment on lines
+21
to
24
| // If we have workflows, redirect to the first one | ||
| if (workflowIds.length > 0) { | ||
| router.replace(`/workspace/${workspaceId}/w/${workflowIds[0]}`) | ||
| return |
Contributor
There was a problem hiding this comment.
logic: No verification that workflows belong to current workspace before redirect. Could cause incorrect routing
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
)" (simstudioai#567) This reverts commit 0049644.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #564